Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering for DiscreteExplicitPOMDP #4

Open
zsunberg opened this issue Jun 7, 2019 · 1 comment
Open

rendering for DiscreteExplicitPOMDP #4

zsunberg opened this issue Jun 7, 2019 · 1 comment

Comments

@zsunberg
Copy link
Member

zsunberg commented Jun 7, 2019

It seems reasonable that someone might want to add visualization or something to their DiscreteExplicitPOMDP or MDP.

To do this, they might need to provide new methods for their specific problem. Perhaps we should provide a key to dispatch on.

struct DiscreteExplicitPOMDP{KEY, ...}
      ...
end

function DiscreteExplicitPOMDP(...; ..., typekey::Symbol=Symbol())
      ...
    return DiscreteExplicitPOMDP{typekey, ...}(...)
end

Then someone can write

render(m::DiscreteExplicitPOMDP{:mykey}, step)
@zsunberg
Copy link
Member Author

zsunberg commented Jun 7, 2019

Actually it might just be more straightforward to add a field called renderobject and do

render(m::DiscreteExplicitPOMDP, step) = render(m.renderobject, step)

@zsunberg zsunberg changed the title key type parameter to allow overloading rendering for DiscreteExplicitPOMDP Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant