Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check "extras" not just "deps" ? #166

Open
bjarthur opened this issue Dec 21, 2019 · 4 comments · May be fixed by #502
Open

check "extras" not just "deps" ? #166

bjarthur opened this issue Dec 21, 2019 · 4 comments · May be fixed by #502
Labels
feature request

Comments

@bjarthur
Copy link

would it make sense to check everything that's in "compat", not just the subset that's also listed in "deps"? the stuff in "extras" seems not to be checked. see GiovineItalia/Compose.jl#374
@devmotion devmotion mentioned this issue Feb 16, 2020
Merged
@exaexa
Copy link

exaexa commented May 11, 2023

Hello, is there anything I can bump/help with to get this implemented?

@sethaxen
Copy link
Contributor

I think with #458, a single-line change to loop over ["deps", "weakdeps", "extras"] instead of just ["deps", "weakdeps"] would resolve this issue.

@exaexa
Copy link

exaexa commented Oct 31, 2023

yeah looks like that's it. I'll try to open another PR when #458 gets merged. (Not sure if adding more stuff to that PR would be good)

@sethaxen
Copy link
Contributor

I agree. Also, for [extras], people may want the ability to opt out of updating that particular section's compats (similar to how they currently need to opt in to test/Project.toml being updated)

This was referenced Sep 5, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider the extras block when checking for new versions andreasnoack/CompatHelper.jl
4 participants
@exaexa @bjarthur @DilumAluthge @sethaxen