Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use DataFrames as input for performance_profile() #48

Open
lrsantos11 opened this issue Feb 4, 2021 · 6 comments
Open

use DataFrames as input for performance_profile() #48

lrsantos11 opened this issue Feb 4, 2021 · 6 comments

Comments

@lrsantos11
Copy link
Contributor

lrsantos11 commented Feb 4, 2021

Using data frames from DataFrames.jl as input for performance_profile() would be usefull.
Perhaps, the syntax could be to have a DataFrame as

df = DataFrames(ProbName=String[],Solver1=Int[],Solver2=Int[],Solver3=Int[])

then push to df the data from each solver and call

performance_profiles(df)

which would use the column name from df as name of the solver, if note given by the user.

@tmigot
Copy link
Member

tmigot commented Mar 15, 2021

I believe this is very similar to performance_profile in SolverBenchmark.jl, where the input is stats::Dict{Symbol,DataFrame} whose keys are solver names and values data frames from the solver call.

@lrsantos11
Copy link
Contributor Author

Sure!

@dpo
Copy link
Member

dpo commented Mar 23, 2021

@lrsantos11 What would be the advantage of pushing data into a DataFrame as opposed to an array? The function in SolverBenchmark extracts data from a DataFrame into an array...

@lrsantos11
Copy link
Contributor Author

lrsantos11 commented Mar 23, 2021

I understand that many have been keeping their results using DFs.

Perhaps moving or copying the performance_profile function in SolverBenchmark.jl as mentioned by @tmigot as it seems to be the solution I was looking for. The advantage is that one do not need to call another package to use this feature.

I thinkg there is no performance (no pun intended) improvement using DFs whatsoever, yet usability will be improved, in my opinion.

@dpo
Copy link
Member

dpo commented Mar 23, 2021

I don’t see any problems with that. @abelsiqueira, how about you?

@lrsantos11 do you want to submit a PR to each repo?

@abelsiqueira
Copy link
Member

I'm happy with it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants