update diagonal QN models #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update follows an update of diagonal QN operators in LinearOperators.jl. See JuliaSmoothOptimizers/LinearOperators.jl#316
|
@tmigot Is there a reason for the |
|
|
|
|
There was no specific reason, and I think your PR clarifies it. The changes look for me, and running locally the tests are passing. So, we just need a new (breaking) release of LinearOperators.jl after JuliaSmoothOptimizers/LinearOperators.jl#316 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 6 6
Lines 887 888 +1
=======================================
+ Hits 864 865 +1
Misses 23 23 ☔ View full report in Codecov by Sentry. |
|
|
I believe the AmplNLReader failure should go away after this PR has been merged. |
tmigot
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update follows an update of diagonal QN operators in LinearOperators.jl.
See JuliaSmoothOptimizers/LinearOperators.jl#316