nest log and throws tests (1.11-nightly compat)

[palday]

I don't know what's changed in the nightly but something about catching the exception messes up the @test_logs check even though the error is still being logged. This fixes that and simplifies things a bit.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c98ad4) 96.32% compared to head (f8e5ece) 96.33%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   96.32%   96.33%           
=======================================
  Files          33       34    +1     
  Lines        3343     3352    +9     
=======================================
+ Hits         3220     3229    +9     
  Misses        123      123           

Flag	Coverage Δ
current	96.33% <100.00%> (?)
minimum	96.23% <100.00%> (+<0.01%)	⬆️
nightly	96.32% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dmbates]

I incorporated the changes to avoid diagind so that the tests on nightly make it through.

[github-actions]

Benchmark Report for /home/runner/work/MixedModels.jl/MixedModels.jl

Job Properties

• Time of benchmarks:
  • Target: 14 Dec 2023 - 22:04
  • Baseline: 14 Dec 2023 - 22:08
• Package commits:
  • Target: 530294
  • Baseline: 4c98ad
• Julia commits:
  • Target: 8e5136
  • Baseline: 8e5136
• Julia command flags:
  • Target: None
  • Baseline: -Cnative,-J/opt/hostedtoolcache/julia/1.9.4/x64/lib/julia/sys.so,-g1,-O3,-e,using Pkg; Pkg.update(); Pkg.add(["BenchmarkTools", "StatsModels"])
• Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
["crossed", "insteval:1"]	0.73 (5%) ✅	1.00 (1%)
["crossed", "machines:1"]	1.04 (5%)	0.98 (1%) ✅
["crossed", "ml1m:1"]	0.89 (5%) ✅	0.78 (1%) ✅
["crossed", "mrk17_exp1:1"]	0.01 (5%) ✅	0.19 (1%) ✅
["crossedvector", "d3:1"]	0.65 (5%) ✅	0.47 (1%) ✅
["crossedvector", "kb07:3"]	0.47 (5%) ✅	1.00 (1%)
["crossedvector", "mrk17_exp1:2"]	0.73 (5%) ✅	0.65 (1%) ✅
["singlevector", "sleepstudy:3"]	0.00 (5%) ✅	0.00 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• ["crossed"]
• ["crossedvector"]
• ["nested"]
• ["singlevector"]

Julia versioninfo

Target

Julia Version 1.9.4
Commit 8e5136fa297 (2023-11-14 08:46 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       1702 s          0 s        207 s       3794 s          0 s
       #2  3242 MHz       1897 s          0 s        446 s       3368 s          0 s
       #3  2592 MHz       1475 s          0 s        281 s       3941 s          0 s
       #4  2462 MHz       1578 s          0 s        261 s       3872 s          0 s
  Memory: 15.60690689086914 GB (13632.3359375 MB free)
  Uptime: 573.68 sec
  Load Avg:  1.68  1.29  0.68
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

Baseline

Julia Version 1.9.4
Commit 8e5136fa297 (2023-11-14 08:46 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       2882 s          0 s        296 s       5157 s          0 s
       #2  3241 MHz       2825 s          0 s        548 s       4971 s          0 s
       #3  2596 MHz       2088 s          0 s        418 s       5821 s          0 s
       #4  2927 MHz       2857 s          0 s        447 s       5040 s          0 s
  Memory: 15.60690689086914 GB (13762.3984375 MB free)
  Uptime: 837.35 sec
  Load Avg:  1.51  1.55  0.98
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, znver3)
  Threads: 1 on 4 virtual cores

[dmbates]

Would it be worthwhile doing a patch release with this PR? It only affects operations on the development branch.

[palday]

@dmbates I don't think this needs to be released -- it's mostly useful for us testing against the nightly builds. If someone really needs it, well it's easy enough to do a quick release.