Adds retime #529
Adds retime #529
Conversation
|
It works off of #528 |
|
@iblislin What do you think about the interface? I have chosen singleton types instead of Symbols so that a dispatch system can be implemented. |
well, I personally prefer the Symbol, and build with literal type dispatching. e.g. julia> f(::Val{:abc}) = 42
f (generic function with 1 method)
julia> f(x::Symbol) = f(Val(x))
f (generic function with 2 methods)
julia> f(:abc)
42but I'm not sure about the performance penalty. Maybe you could give that a try. |
|
@iblislin I added a documentation page as well. |
|
Could you sync (rebase or just merge) this branch with master? |
minor return iterator and adds test starts to add retime changes _split changes LTS overload Base.split changes interface of _split to return timestamps
adds missing deps another missing dep support symbols as well handle missing data adds docs on retime minor
ValentinKaisermayer
force-pushed
the
vk-retime
branch
from
095736e to
48d72ab
Compare
Done |
|
@iblislin any thoughts? |
|
Any idea about the Documenter build failures? Tons of |
| new_values = __get_new_values( | ||
| T, length(new_timestamps), size(values(ta), 2), extrapolate, skip_missing | ||
| ) | ||
| old_timestamps = convert(Vector{DN}, timestamp(ta)) |
There was a problem hiding this comment.
not sure why the convert is needed?
There was a problem hiding this comment.
This is since Dates.value is different for Dates and DateTimes. But the source TimeArray and the given time vector might are different.
Not really. |
Closes #439