-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support some convenient warpper functions? #44
Comments
This is something I often need but rather amazingly does not seem to exist in Julia. Would maintainers be receptive to doing that in this package or should it be done in a separate package? |
Not sure I count as a maintainer (haven't contributed a single line of code to this package), but it looks a good idea to me. This is light wrapper around |
Yeah, we are sitting on a very nice namespace here, so we might as well use it. The one thing I would ask is that we try to keep 100% coverage for all of these convenience functions; that should help prevent them from regressing. |
Hm, I was thinking that tests might be hard but I guess it's always safe to assume we can talk to the repo for the project itself? Then we might have branches or tags purely for testing purposes which is kind of a fun quirk. Anyway, I might make some contributions as I have already done "quick and dirty" versions of this 2 or 3 times and it would certainly seem worth it to do it for real before I have to do it again. 100% coverage might be tricky but I'll give it a shot if I do make a PR. |
I'm wondering if people are open to have some convenient functions in this package? e.g
I think it would be nice to have some convenient Julian functions like these in this package so that we can just use them as
Git.default_branch
etc. instead of searching how to do X then do the interpolations manually.The reason why I don't like them in a separate package is that I find this package is already wrapping
Git_jll
and the module nameGit
is shorter than a separate one such asGitHelper
, what do you think?The text was updated successfully, but these errors were encountered: