Clean up connections before exit in tests #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes various alarming finalizer errors when running the tests - in those cases, sockets appear to have been closed before the finalizer gets to run.
filchristou
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Hey. I am fine with that. ssh connections are now the default tests and also work with the CI.
I also like the Base.active_project() approach. it's a nice not intrusive solution (wrt TestEnv).
Also all these "soft erros" from #70 stopped. so thanks for that!
|
@filchristou Indeed, it seems we're using ssh in CI... Now I'm confused, I don't know why I thought this didn't work! Looking at the CI config it seems I did spend a lot of effort getting ssh working back in #2. Honestly I can't remember going through that pain 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various alarming finalizer errors when running the tests - in those cases, sockets appear to have been closed before the finalizer gets to run.
Also make sure to run the test RemoteREPL server processes in the Julia environment set up by the test runner.
Fix #70