From ac06e21a3ea38e66ff15393be3c91b97bb276581 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mi=C5=82osz=20Kosobucki?= Date: Thu, 11 Jul 2024 16:12:53 +0200 Subject: [PATCH] Don't fail fast It's a nightly, better use the time to check the whole thing on all configurations. Unfortunately, with "continue-on-error: true" GitHub actions will still mark the workflow run as successful even if all the steps fail. However, we'd like to run Cppcheck even if clang-tidy gets errors. Not possible, it's a limitation of GitHub actions documented in: - https://github.com/actions/runner/issues/2347 - https://github.com/orgs/community/discussions/15452 GitHub folks collected feedback for this over a year ago: https://github.com/orgs/community/discussions/15452#discussioncomment-5184613 but it's still not fixed. --- .github/workflows/nightly.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 4c1fdee..e9317dc 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -27,6 +27,7 @@ jobs: - name: Windows os: windows-2022 tidy-executble: clang-tidy + fail-fast: false continue-on-error: true steps: