Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not running with node >19 #3

Open
KristjanESPERANTO opened this issue Oct 14, 2024 · 5 comments
Open

Not running with node >19 #3

KristjanESPERANTO opened this issue Oct 14, 2024 · 5 comments

Comments

@KristjanESPERANTO
Copy link

node v18.20.2:

ajv not up to date: [ current: ^8.17.0 | latest: 8.17.1]

node v19.0.0:

ajv not up to date: [ current: ^8.17.0 | latest: 8.17.1]

node v20.18.0:

Cannot read properties of undefined (reading 'ajv')

node v22.8.0:

Cannot read properties of undefined (reading 'ajv')
(node:40618) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
@KID-joker
Copy link
Owner

I tried it and ndc runs fine in the node environment you listed. Can you provide more information, such as ndc version, run command, package.json and lockfile? Thanks for your feedback.

@KristjanESPERANTO
Copy link
Author

KristjanESPERANTO commented Oct 15, 2024

Strange. Now it doesn't even work under node 18 🤔

# system information
$ uname -a
Linux debian 5.10.0-20-amd64 #1 SMP Debian 5.10.158-2 (2022-12-13) x86_64 GNU/Linux

# distribution information
$ cat /etc/*-release
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
...


# node version
$ node -v
v22.8.0


# install ndc globally
$ npm install -g npm-deprecated-check
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported

changed 91 packages in 2s

21 packages are looking for funding
  run `npm fund` for details


# ndc version
$ ndc -V
npm-deprecated-check 1.0.2


# minimal package.json
$ cat package.json 
{
  "name": "ndc-test",
  "version": "1.0.0",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "description": "",
  "dependencies": {
    "ajv": "^8.17.0"
  }
}


# check fails
$ ndc current
Cannot read properties of undefined (reading 'ajv')
(node:8964) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)


# install ndc in the project locally
$ npm install npm-deprecated-check
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported

added 91 packages, and audited 97 packages in 7s

22 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities


# run ndc locally -> check fails
$ npx ndc current
Cannot read properties of undefined (reading 'ajv')
(node:9150) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

# switch to node 18
$ nvm use 18
Now using node v18.20.2 (npm v10.5.0)


# install ndc globally
$ npm install -g npm-deprecated-check
npm WARN deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported

added 91 packages in 8s

21 packages are looking for funding
  run `npm fund` for details


# check fails
$ ndc current
Cannot read properties of undefined (reading 'ajv')


# install ndc locally
$ npm install npm-deprecated-check

up to date, audited 97 packages in 1s

22 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities


# run ndc locally -> check fails
$ npx ndc current
Cannot read properties of undefined (reading 'ajv')

@KristjanESPERANTO
Copy link
Author

Just checked on a windows system with node 20. Same problem: Cannot read properties of undefined (reading ....

@KID-joker
Copy link
Owner

What about ndc package ajv?

@KristjanESPERANTO
Copy link
Author

Tested on the debian system -> Just short ⠋ Checking then nothing:

$ nvm use 18
Now using node v18.20.2 (npm v10.5.0)
$ ndc package avj
$
$ nvm use 20
Now using node v20.18.0 (npm v10.8.2)
$ ndc package avj
$
$ nvm use 22
Now using node v22.8.0 (npm v10.8.2)
$ ndc package avj
⠋ Checking(node:9345) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants