Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define formatting/writing style points? #326

Open
eldering opened this issue Aug 20, 2024 · 5 comments
Open

Define formatting/writing style points? #326

eldering opened this issue Aug 20, 2024 · 5 comments
Labels
wordsmith Improving wording, grammar etc.

Comments

@eldering
Copy link
Collaborator

While getting down to the the small details, there's been plenty of fixes and sometimes overriding of previous changes in regards to things like table layouts. What about collecting some points of what we try to adhere to?

Some points to consider:

  • Use _ for italics and ** for bold in markdown
  • How do we format tables? For example, do we use a prefix |?
  • Spelling issues, for example, do we want to consistently write e.g. and i.e. as for example and that is?
  • ....
@eldering eldering added the wordsmith Improving wording, grammar etc. label Aug 20, 2024
@niemela
Copy link
Member

niemela commented Aug 20, 2024

While getting down to the the small details, there's been plenty of fixes and sometimes overriding of previous changes in regards to things like table layouts. What about collecting some points of what we try to adhere to?

Yes, we should agree on style. 👍

Should we even add this to some readme somewhere? Maybe the one in the root?

Some points to consider:

* Use `_` for italics and `**` for bold in markdown

Sounds good to me. I've been trying to consistently change into exactly this.

* How do we format tables? For example, do we use a prefix `|`?

I have been changing into the following:

  • No prefix |.
  • No postfix |
  • Exactly one space between ---s and |s in the header divider row on each side
  • Match width of columns for all rows (i.e. all are as wide as the largest), except when that becomes unreasonable.
  • Match width of columns between format versions, when tables exists in both, to allow useful diffs.
  • Last header divider matches the length of the header, not the contents

Some of these might be a bit controversial, so feel free to disagree and discuss.

My reasons for these particular choices is to keep line lengths as short as possible (since you can't line break tables), and keep diffs as useful as possible.

* Spelling issues, for example, do we want to consistently write `e.g.` and `i.e.` as `for example` and `that is`?

I prefer e.g. and i.e. when that is what you mean.

* ....
  • Add newlines to make diffs maximally useful. I.e. newline after ever sentence, and newline at subclauses (i.e. after ,) when the sentence becomes too long and it makes semantic sense.

@eldering
Copy link
Collaborator Author

Should we even add this to some readme somewhere? Maybe the one in the root?

Yes, but not sure it should be directly user facing. Maybe a style-guide.md in the root or something like this.

Some points to consider:

* Use `_` for italics and `**` for bold in markdown

Sounds good to me. I've been trying to consistently change into exactly this.

Indeed, and I'm fine with this.

* How do we format tables? For example, do we use a prefix `|`?

I have been changing into the following:

* No prefix `|`.
* No postfix `|`
* Exactly one space between `---`s and `|`s in the header divider row on each side
* Match width of columns for all rows (i.e. all are as wide as the largest), except when that becomes unreasonable.
* Match width of columns between format versions, when tables exists in both, to allow useful diffs.
* Last header divider matches the length of the header, not the contents

Some of these might be a bit controversial, so feel free to disagree and discuss.

My reasons for these particular choices is to keep line lengths as short as possible (since you can't line break tables), and keep diffs as useful as possible.

Sounds fine to me.

* Spelling issues, for example, do we want to consistently write `e.g.` and `i.e.` as `for example` and `that is`?

I prefer e.g. and i.e. when that is what you mean.

I'd prefer the full written out for example and that is. It is a bit longer, but it is clearer, especially to people who are not (near) native english speakers and/or have Latin knowledge. I think it also leads to fewer small issues like those fixed in #325.

* ....
* Add newlines to make diffs maximally useful. I.e. newline after ever sentence, and newline at subclauses (i.e. after `,`) when the sentence becomes too long _and_ it makes semantic sense.

Sounds fine to me, although I think we also shouldn't reformat text too much to put it in exactly this format, as that also decreases diff clarity.

@Tagl
Copy link
Contributor

Tagl commented Aug 20, 2024

Relevant: #307

@eldering
Copy link
Collaborator Author

Relevant: #307

I'd strongly prefer to capitalize headers like normal sentences.

@JoelNiemela
Copy link
Collaborator

I agree with @niemela's comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wordsmith Improving wording, grammar etc.
Projects
None yet
Development

No branches or pull requests

4 participants