-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider remove error_chain dependency #297
Comments
That's a breaking change so for the next major version. Related recent discussion: https://www.reddit.com/r/rust/comments/8lt8k6/do_i_really_need_failureerrorchain/ Failure seems nice but not really actively maintained so maybe going the plain enum would be better, depending on the timeline for the next major version |
Looks like some of Failure is coming to Std so it would be better to wait before making a breaking change: https://www.reddit.com/r/rust/comments/92kozl/feedback_needed_upcoming_failure_012_release/e36pf5w/?context=0 |
So the way to go is probably plain std Error enum since using Once we have it working, we can also add more error types like the ones from #322 |
Related to rust-lang-deprecated/error-chain#240,
tera::Error
instances are!Sync
.For example, it is impossible to return
tera::Error
directly from theactix-web
handler, and it is easier just to suppress it: https://github.com/actix/examples/blob/master/template_tera/src/main.rs#L28Since
tera::Error
is quite simple, it might be worth to replaceerror_chain!
call with a plain enum or use the failure crate.The text was updated successfully, but these errors were encountered: