Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.inference: make default match_finder and knn_func use same distance metric #430

Open
KevinMusgrave opened this issue Feb 16, 2022 · 1 comment · May be fixed by #643
Open

utils.inference: make default match_finder and knn_func use same distance metric #430

KevinMusgrave opened this issue Feb 16, 2022 · 1 comment · May be fixed by #643
Labels
enhancement New feature or request
Milestone
v3.0

Comments

@KevinMusgrave
Copy link
Owner

Also it might be possible to replace the functionality of match_finder with knn_func
@KevinMusgrave KevinMusgrave added the enhancement New feature or request label Feb 16, 2022
@KevinMusgrave KevinMusgrave mentioned this issue Feb 16, 2022
Closed
@KevinMusgrave
Copy link
Owner Author

Relevant issue: #429

domenicoMuscill0 added a commit to domenicoMuscill0/pytorch-metric-learning that referenced this issue Jun 24, 2023
@domenicoMuscill0
Fixed issues KevinMusgrave#430 and KevinMusgrave#602.
dc89907 
Removed Match_Finder as pointed out in KevinMusgrave#430
@KevinMusgrave KevinMusgrave added this to the v3.0 milestone Jul 3, 2023
@KevinMusgrave KevinMusgrave linked a pull request Jul 3, 2023 that will close this issue
Fixed issues #491, #430 and #602 #643
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Fixed issues #491, #430 and #602 domenicoMuscill0/pytorch-metric-learning
1 participant
@KevinMusgrave