Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material 3 support #2

Open
mainrs opened this issue Feb 15, 2024 · 5 comments
Open

Material 3 support #2

mainrs opened this issue Feb 15, 2024 · 5 comments

Comments

@mainrs
Copy link

mainrs commented Feb 15, 2024

Hello!

Having this library rely on material3 instead of material would allow for proper theming functionality (like dynamic themes) to work properly!

Thank you for the great library!

@KevinnZou
Copy link
Owner

@mainrs Thanks for your suggestion! I will upgrade it to Material3 when I am back from vacation.

@mainrs
Copy link
Author

mainrs commented Feb 16, 2024

Thank you!

@KevinnZou
Copy link
Owner

KevinnZou commented Feb 21, 2024

@mainrs After researching, I discovered that the Modifier.swipeable we are using in this library is from Material2 and is not available in Material3. Therefore, unfortunately, we may not be able to upgrade to it currently.

@mainrs
Copy link
Author

mainrs commented Feb 21, 2024

The API has actually been renamed and moved into foundation:
https://developer.android.com/jetpack/compose/touch-input/pointer-input/migrate-swipeable

@KevinnZou
Copy link
Owner

Yes, we also noticed that and have just migrated to anchoredDraggable for the Android version of this library. We will also do it for the multiplatform version once Compose 1.6.0 is stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants