Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK references pinned versions of React, causing duplicate dependencies #81

Open
jordaaash opened this issue Oct 15, 2022 · 1 comment

Comments

@jordaaash
Copy link
Contributor

https://github.com/KeystoneHQ/keystone-airgaped-base/blob/67cadb8af7207adfa5de20094dc82c8cfb00831a/packages/sdk/package.json#L30-L55

This code pins the version of React + DOM to 16.13.1. Any React app that uses this library will end up with two versions of these dependencies, causing bundle bloat and other issues.

Additionally the dev dependencies of the same packages use newer versions, and are unpinned.

React applications should provide their own version of React, and libraries that need it should declare flexible peer dependencies and dev dependencies instead.

@peterpme
Copy link
Contributor

Hi @zhaomengru2015, is it possible to merge this in? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants