From a9b02dfa190817d5abf8f7c62b014e7ee574a437 Mon Sep 17 00:00:00 2001 From: Juan Andrade Date: Fri, 20 Oct 2023 17:28:25 -0400 Subject: [PATCH] =?UTF-8?q?[=F0=9F=94=A5AUDIT=F0=9F=94=A5]=20Run=20snapsho?= =?UTF-8?q?ts=20job=20when=20the=20PR=20is=20ready=20for=20review=20(#2095?= =?UTF-8?q?)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🖍 _This is an audit!_ 🖍 ## Summary: The snapshot releases job only runs when the PR is not a draft. There was an issue that prevented from creating a snapshot release when a PR was moved from `draft` to `ready for review`. This PR fixes that by including the `ready_for_review` activity type in the workflow. Issue: XXX-XXXX ## Test plan: N/A Author: jandrade Auditors: nishasy Required Reviewers: Approved By: nishasy Checks: ❌ codecov/project, ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 16.x), ✅ Test (ubuntu-latest, 16.x, 2/2), ✅ Test (ubuntu-latest, 16.x, 1/2), ✅ Lint (ubuntu-latest, 16.x), ✅ Check build sizes (ubuntu-latest, 16.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 16.x), ✅ Publish npm snapshot (ubuntu-latest, 16.x), ⏭ Chromatic - Skip on Release PR (changesets), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 16.x), ⏭ dependabot, ✅ gerald, ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x) Pull Request URL: https://github.com/Khan/wonder-blocks/pull/2095 --- .github/workflows/node-ci-pr.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/node-ci-pr.yml b/.github/workflows/node-ci-pr.yml index 10d6624f2..600dc9e9c 100644 --- a/.github/workflows/node-ci-pr.yml +++ b/.github/workflows/node-ci-pr.yml @@ -2,7 +2,9 @@ name: Node CI (PR) on: pull_request: - types: [edited, opened, synchronize, reopened] + # ready_for_review is useful for when a PR is converted from "draft" to "not + # draft". + types: [edited, opened, synchronize, ready_for_review, reopened] # Our jobs run like this to minimize wasting resource cycles: # 1. Prime caches for primary configuration (ubuntu on node 16).