Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xml] IglooFunctionSelectSGIX group used but not properly defined #357

Closed
SunSerega opened this issue Jan 26, 2020 · 7 comments · Fixed by #375
Closed

[xml] IglooFunctionSelectSGIX group used but not properly defined #357

SunSerega opened this issue Jan 26, 2020 · 7 comments · Fixed by #375
Assignees

Comments

@SunSerega
Copy link
Contributor

SunSerega commented Jan 26, 2020

        <command>
            <proto>void <name>glIglooInterfaceSGIX</name></proto>
            <param group="IglooFunctionSelectSGIX"><ptype>GLenum</ptype> <name>pname</name></param>
            <param group="IglooParameterSGIX" len="COMPSIZE(pname)">const void *<name>params</name></param>
            <glx type="render" opcode="200"/>
        </command>

There is only commented out group defined with depricated syntax:

        <group name="IglooFunctionSelectSGIX" comment="Private (internal) extension SGIX_igloo_interface">
            <!--<enum name="GL_IGLOO_FULLSCREEN_SGIX"/>-->
            <!--<enum name="GL_IGLOO_VIEWPORT_OFFSET_SGIX"/>-->
            <!--<enum name="GL_IGLOO_SWAPTMESH_SGIX"/>-->
            <!--<enum name="GL_IGLOO_COLORNORMAL_SGIX"/>-->
            <!--<enum name="GL_IGLOO_IRISGL_MODE_SGIX"/>-->
            <!--<enum name="GL_IGLOO_LMC_COLOR_SGIX"/>-->
            <!--<enum name="GL_IGLOO_TMESHMODE_SGIX"/>-->
        </group>

I understand that SGIX_igloo_interface is not just internal, but also deprecated extension.
But IglooFunctionSelectSGIX group is used by function xml, so it still need's to be properly defined in same xml.

@Perksey
Copy link
Contributor

Perksey commented Jan 26, 2020

I think the best solution here is to comment out all remnants of that extension entirely, or remove the group attributes from the parameters.

@SunSerega
Copy link
Contributor Author

SunSerega commented Jan 27, 2020

I would prefer to have all remains commented out, over leaving <ptype>GLenum</ptype> parameter without group attribute. (talking of which)

But i don't think it would hurt to still support this extension.

@oddhack
Copy link
Collaborator

oddhack commented Jan 27, 2020

This is an ancient SGI extension kept around for historical completeness. It was actually not intended for use by anything but Igloo, SGI's Iris GL -> OpenGL translation layer, and exceedingly unlikely to be supported by anything built in the last decade. There is no harm in un-commenting the enums for this private extension although very little utility either - it's really just there in case for some reason in the future, someone wants to know what that extension or enum was about.

@SunSerega
Copy link
Contributor Author

although very little utility either

Well, as i said - i already read that it's internal and deprecated before posting. But still posted for completeness sake. The fact that group can be used, but not defined is not documented in .pdf, and sounds too wrong to be documented.

But it should be okay to mark the extension being dead as you said in #358, and then leave <ptype>GLenum</ptype> without group attribute. Because dead extensions, as you said, should be ignored by code using .xml's.

@Perksey
Copy link
Contributor

Perksey commented Jan 27, 2020

But it should be okay to mark the extension being dead as you said in #358, and then leave GLenum without group attribute. Because dead extensions, as you said, should be ignored by code using .xml's.

I think this is probably the best solution

@pdaniell-nv
Copy link
Contributor

@Perksey I notice there are a bunch of issues you've added to your todo list. Shall I assign those issues to you?

@Perksey
Copy link
Contributor

Perksey commented Feb 18, 2020

Yeah that's probably best, thanks.

@pdaniell-nv pdaniell-nv added this to the Needs Action/PR milestone Feb 19, 2020
Perksey added a commit to Perksey/OpenGL-Registry that referenced this issue Mar 6, 2020
@Perksey Perksey mentioned this issue Mar 6, 2020
oddhack pushed a commit that referenced this issue Mar 11, 2020
* Fix #355

* Fix #356

* Fix #357

* Fix #358

* Add groups to grouped blocks, fixes #359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants