From b0103be3d26ff2fc6b82cffe3f2eea1ac5a9c868 Mon Sep 17 00:00:00 2001 From: "Cai, Justin" Date: Thu, 12 Oct 2023 08:35:45 -0700 Subject: [PATCH 1/2] Enable range rounding for range tests --- tests/range/CMakeLists.txt | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tests/range/CMakeLists.txt b/tests/range/CMakeLists.txt index 82f462065..57bf35048 100644 --- a/tests/range/CMakeLists.txt +++ b/tests/range/CMakeLists.txt @@ -1,3 +1,10 @@ file(GLOB test_cases_list *.cpp) +if(SYCL_IMPLEMENTATION STREQUAL "DPCPP") + # For DPCPP, range rounding is disabled globally. However, + # the range_api test needs range rounding enabled to pass, + # so renable it here. + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -U__SYCL_DISABLE_PARALLEL_FOR_RANGE_ROUNDING__") +endif() + add_cts_test(${test_cases_list}) From 76b03b9ad13e61e1814e47a77acb0221ec37d796 Mon Sep 17 00:00:00 2001 From: "Cai, Justin" Date: Thu, 12 Oct 2023 09:05:12 -0700 Subject: [PATCH 2/2] Edit comment --- tests/range/CMakeLists.txt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/range/CMakeLists.txt b/tests/range/CMakeLists.txt index 57bf35048..a9b389e41 100644 --- a/tests/range/CMakeLists.txt +++ b/tests/range/CMakeLists.txt @@ -1,9 +1,11 @@ file(GLOB test_cases_list *.cpp) if(SYCL_IMPLEMENTATION STREQUAL "DPCPP") - # For DPCPP, range rounding is disabled globally. However, - # the range_api test needs range rounding enabled to pass, - # so renable it here. + # in FindDPCPP.cmake, range rounding is disabled globally to reduce + # the number of kernels generated per range parallel_for. However, + # range rounding enables launching of kernels over >32bit ranges, + # and the range_api test in full conformance such kernel launches + # over large ranges, so we renable it here. set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -U__SYCL_DISABLE_PARALLEL_FOR_RANGE_ROUNDING__") endif()