Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textures without fallbacks require extensions #157

Open
emackey opened this issue Jan 6, 2021 · 2 comments
Open

Textures without fallbacks require extensions #157

emackey opened this issue Jan 6, 2021 · 2 comments

Comments

@emackey
Copy link
Member

emackey commented Jan 6, 2021

Any texture that fails to supply a source image should (must?) supply at least one required extension.

For example:

"textures": [
    {
      "sampler": 0,
      "extensions": {
        "KHR_texture_basisu": {
          "source": 2
        }
      }
    },

The above block implies that KHR_texture_basisu (or whatever extension may be used there) should be listed under extensionsRequired because otherwise there is no texture source.

/cc KhronosGroup/glTF-Sample-Models#285

It might also be good to flag if the source is missing and there aren't any extensions:

"textures": [
    {
      "sampler": 0
    },
@lexaknyazev
Copy link
Member

There could potentially be a root-level extension like EXT_texture_default that provides a universal fallback image for all textures without defined source.

That said, I agree that assets with texture objects using BasisU extension without fallback should usually require BasisU extension.

@emackey
Copy link
Member Author

emackey commented Jan 6, 2021

Interesting. Can we at least say that extensionsRequired must be present (not empty) in any glTF that omits a texture source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants