Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with jQuery jQuery 3.21./jQueryUI 1.12.1 #80

Closed
lcfink opened this issue Nov 16, 2017 · 4 comments
Closed

Error with jQuery jQuery 3.21./jQueryUI 1.12.1 #80

lcfink opened this issue Nov 16, 2017 · 4 comments

Comments

@lcfink
Copy link

lcfink commented Nov 16, 2017

Picker loads with month-picker-previous and month-picker-next buttons disabled.

The problem seems to be that _value is null (not false, but falsie) on input.
The check if (_btnWidget.option('disabled') !== _value) is true, so _btnWidget.option('disabled', _value) executes, which disables the buttons.

An easy fix is to validate _value:
_value = !(!_value);

@KidSysco
Copy link
Owner

Good find, we should probably try to support jQuery 3.x sometime soon.

@lcfink
Copy link
Author

lcfink commented Nov 16, 2017

If I may say, I've tested pretty thoroughly in my applications, and plan to deploy your month picker running in 3.x, with my manual fix. That's the only issue I found.

@KidSysco
Copy link
Owner

OK great, I was going to say that @ComiR at #79 found another way to address this issue. It passed all of our unit tests too. I should probably merge that up soon and it should address this issue. Thanks for chiming in!

@benjamin-albert
Copy link
Collaborator

Welcome to GitHub @lcfink

Thank you for opening an issue and expressing interest in jQuery UI 1.12 and jQuery 3 support.

Supporting jQuery UI 1.12 is being discussed in #73 which includes the fix you're proposing and other important fixes which address the visual glitches.

Let's continue the discussion around supporting jQuery UI 1.12 and jQuery 3 in #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants