Test: add many e2e test #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- insert.slt - join_left_inner.slt - limit.slt - where.slt tips: fix `limit` operator
loloxwg
approved these changes
Oct 13, 2023
lewiszlw
reviewed
Oct 14, 2023
tests/slt/insert.slt
Outdated
| @@ -0,0 +1,33 @@ | |||
| statement ok | |||
| create table t(id int primary key, v1 int null, v2 int null, v3 int null) | |||
There was a problem hiding this comment.
Could you use multi types here？
| insert into y values (0, 1, 5), (1, 1, 6), (2, 2, 7); | ||
|
|
||
| query IIII | ||
| select a, b, c, d from x join y on a = c; |
There was a problem hiding this comment.
The file name is join_left_inner, why you test inner join here?
There was a problem hiding this comment.
The file name is join_left_inner, why you test inner join here?
for risinglight
https://github.com/risinglightdb/risinglight/blob/main/tests/sql/join_left_inner.slt
lewiszlw
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tips:
limitoperator:Some(0), causing some problems.e2e sqllogictestCode changes
Check List
Tests
Side effects
Note for reviewer