Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode_to_slice with _upper and _lower variants #45

Open
peku33 opened this issue May 30, 2020 · 0 comments · May be fixed by #64
Open

encode_to_slice with _upper and _lower variants #45

peku33 opened this issue May 30, 2020 · 0 comments · May be fixed by #64
Assignees
@KokaKiwi
Labels
enhancement
Milestone
1.0

Comments

@peku33
Copy link

peku33 commented May 30, 2020

At the moment there is no way to choose between case mode when using allocation free encode_to_slice. Current behavior defaults to lowercase.

My proposal is to:
change encode_to_slice -> encode_to_slice_lower add encode_to_slice_upper`

let (high, low) = byte2hex(*byte, HEX_CHARS_LOWER);
HEX_CHARS_LOWER could be easily parametrized
@KokaKiwi KokaKiwi self-assigned this May 30, 2020
@KokaKiwi KokaKiwi added this to the 1.0 milestone May 30, 2020
taiki-e added a commit to taiki-e/rust-hex that referenced this issue Aug 28, 2021
@taiki-e
Add encode_to_slice_upper to improve performance of encode_upper
54e649d 
This also fixes KokaKiwi#45.
taiki-e added a commit to taiki-e/rust-hex that referenced this issue Aug 28, 2021
@taiki-e
Add encode_to_slice_upper to improve performance of encode_upper
8b9307b 
This also fixes KokaKiwi#45.
@taiki-e taiki-e linked a pull request Aug 28, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KokaKiwi KokaKiwi

Labels
enhancement
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Improve performance of encoding taiki-e/rust-hex
2 participants
@KokaKiwi @peku33