Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hex::FromHex::Error does not implement Eq #76

Open
tcharding opened this issue Dec 13, 2022 · 1 comment
Open

hex::FromHex::Error does not implement Eq #76

tcharding opened this issue Dec 13, 2022 · 1 comment
Labels
enhancement

Comments

@tcharding
Copy link

Is there some reason why FromHexError does not derive Eq? It seems common in the Rust std lib to do so, here are a bunch of example errors that do so: https://doc.rust-lang.org/std/cmp/trait.Eq.html

Happy to do a PR but its so trivial I thought there might be some reason I can't work out.

Thanks
@nouritsu nouritsu mentioned this issue Jul 17, 2023
Merged
@nouritsu
Copy link

Are there plans to work on this?

@nouritsu nouritsu mentioned this issue Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(FromHexError): derive Eq for enum FromHexError
3 participants
@KokaKiwi @tcharding @nouritsu