From f00b8503a0122778907d0692291d47ac41956217 Mon Sep 17 00:00:00 2001 From: Mattia Lavacca Date: Mon, 17 Jun 2024 14:34:16 +0200 Subject: [PATCH] chore: explictly return values Signed-off-by: Mattia Lavacca --- controller/gateway/controller_reconciler_utils.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/controller/gateway/controller_reconciler_utils.go b/controller/gateway/controller_reconciler_utils.go index 2b2fabcc2..6a975d94d 100644 --- a/controller/gateway/controller_reconciler_utils.go +++ b/controller/gateway/controller_reconciler_utils.go @@ -882,7 +882,7 @@ func getSupportedKindsWithResolvedRefsCondition(ctx context.Context, c client.Cl referenceGrantList := &gatewayv1beta1.ReferenceGrantList{} err = c.List(ctx, referenceGrantList, client.InNamespace(secretNamespace)) if err != nil { - return + return nil, metav1.Condition{}, fmt.Errorf("failed to list ReferenceGrants: %w", err) } if !isSecretCrossReferenceGranted(gatewayv1.Namespace(gatewayNamespace), certificateRef.Name, referenceGrantList.Items) { resolvedRefsCondition.Reason = string(gatewayv1.ListenerReasonRefNotPermitted) @@ -901,7 +901,7 @@ func getSupportedKindsWithResolvedRefsCondition(ctx context.Context, c client.Cl }, certificateSecret) if err != nil { if !k8serrors.IsNotFound(err) { - return + return nil, metav1.Condition{}, fmt.Errorf("failed to get Secret: %w", err) } resolvedRefsCondition.Reason = string(gatewayv1.ListenerReasonInvalidCertificateRef) message = conditionMessage(message, fmt.Sprintf("Referenced secret %s/%s does not exist", secretNamespace, certificateRef.Name))