-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fill in AttachedRoutes in Gateways' Listeners status #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
gateway-api-attached-routes
branch
from
May 9, 2024 12:36
9fd853e
to
73ecc2a
Compare
mlavacca
reviewed
May 14, 2024
pmalek
force-pushed
the
gateway-api-attached-routes
branch
from
May 21, 2024 15:42
a1ce712
to
4c515c8
Compare
pmalek
force-pushed
the
gateway-api-attached-routes
branch
from
May 21, 2024 15:42
4c515c8
to
5dd6765
Compare
…ector to selector
Co-authored-by: Jakub Warczarek <[email protected]>
Co-authored-by: Jakub Warczarek <[email protected]>
programmer04
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for setting the correct
attachedRoutes
count inGateway
's listeners status.Which issue this PR fixes
Part of #56
Special notes for your reviewer:
TestGatewayConformance/GatewayWithAttachedRoutes/Gateway_listener_should_have_AttachedRoutes_set_even_when_Gateway_has_unresolved_refs
fails because for some reasonHTTPRoute
's status flips back and forth betweenand
Which I couldn't reproduce outside of conformance tests with manifests from https://github.com/kubernetes-sigs/gateway-api/blob/8b7639171b5ae5007c8a7abd1796f02a053313cf/conformance/tests/gateway-with-attached-routes.yaml#L90-L132
Below, I attach the dump of logs and resources as retrieved from the cluster during the conformance tests run. It seems that we do not set the
ResolvedRefs
condition on theGateway
properly when the tls secret that's referenced by the listener does not exist. That should be resolved separately when working on HTTPS/TLS routesPR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect significant changes