tests: add helm upgrade tests #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
helm-upgrade-tests
branch
2 times, most recently
from
e66cdeb
to
7972254
Compare
pmalek
force-pushed
the
helm-upgrade-tests
branch
17 times, most recently
from
4487fd8
to
47a4ed3
Compare
pmalek
force-pushed
the
helm-upgrade-tests
branch
2 times, most recently
from
e06832f
to
f015318
Compare
programmer04
reviewed
May 6, 2024
czeslavo
reviewed
May 6, 2024
czeslavo
reviewed
May 6, 2024
czeslavo
reviewed
May 6, 2024
Good point. I've created https://github.com/Kong/gateway-operator-enterprise/pull/137 to test this |
czeslavo
reviewed
May 6, 2024
Co-authored-by: Jakub Warczarek <[email protected]>
@programmer04 https://github.com/Kong/gateway-operator-enterprise/pull/137#issuecomment-2096470896 |
czeslavo
approved these changes
May 6, 2024
programmer04
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds some basic scaffolding for helm upgrade tests
Which issue this PR fixes
Part of #155
Special notes for your reviewer:
In order to perform update form pre 1.2 to 1.2+ we need to be able to disableControlPlaneandGatewaycontrollers because their respective CRDs (ControlPlaneandGatewayConfiguration) got a breaking change in 1.2 (bump fromv1alpha1tov1betawithout a KGO version that would allow a smooth transition).This requires a change in the chart which would allow setting args because only KGO 1.2+ supports configuration via env. Kong/charts#1058 implements that.The upgrade from pre 1.2 to 1.2 and up is not done as helm chart (used in this test suite) only contains the CRDs from 1.2 and since helm still doesn't provide CRD management there's no easy way to achieve that (well apart from applying the CRDs manually but we'd need to add manual steps for that).
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes