From 648fcc80774aa093bf4624d4f5cf7634793ac98d Mon Sep 17 00:00:00 2001 From: Travis Raines <571832+rainest@users.noreply.github.com> Date: Fri, 5 Aug 2022 11:30:23 -0700 Subject: [PATCH] fix: use correct command for describe (#343) --- CHANGELOG.md | 7 +++++++ pkg/clusters/cleanup.go | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fdb3a70b..a3cf9431 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,16 +3,23 @@ ## v0.19.0 ### Added + - Added feature to support waiting for a port of a service to be connective by TCP. [#338](https://github.com/Kong/kubernetes-testing-framework/pull/338) ### Improved + - Increased retry times to increase the timeout to wait for kuma webhook to be ready to serve. [#341](https://github.com/Kong/kubernetes-testing-framework/pull/341) [#342](https://github.com/Kong/kubernetes-testing-framework/pull/342) +### Fixed + +- Diagnostics runs the correct command for `kubectl describe`. + [#343](https://github.com/Kong/kubernetes-testing-framework/pull/343) + ## v0.18.0 ### Added diff --git a/pkg/clusters/cleanup.go b/pkg/clusters/cleanup.go index 19d4c0f1..6ce85198 100644 --- a/pkg/clusters/cleanup.go +++ b/pkg/clusters/cleanup.go @@ -83,7 +83,7 @@ func (c *Cleaner) DumpDiagnostics(ctx context.Context, meta string) (string, err if err != nil { return output, err } - cmd = exec.CommandContext(ctx, "kubectl", "--kubeconfig", kubeconfig.Name(), "get", "all", "--all-namespaces", "-o", "yaml") //nolint:gosec + cmd = exec.CommandContext(ctx, "kubectl", "--kubeconfig", kubeconfig.Name(), "describe", "all", "--all-namespaces") //nolint:gosec cmd.Stdout = describeAllOut if err := cmd.Run(); err != nil { return output, err