Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Unified account - Bug related to Connect dApp #1839

Closed
8 tasks done
ThaoNguyen998 opened this issue Nov 19, 2024 · 5 comments
Closed
8 tasks done

Mobile - Unified account - Bug related to Connect dApp #1839

ThaoNguyen998 opened this issue Nov 19, 2024 · 5 comments
Assignees
Milestone

Comments

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Nov 19, 2024

Describe the task

  • Show incorrect status when connected dapp
    Actual: Show incorrect status connect

    ScreenRecording_11-19-2024.16-25-31_1.MP4

    Expect: Display correct status

  • Show incorrect list account on popup connect account

  • Hide address on list account connect on dApp details
    Actual: Show address

Image

Expect: Hide address


WalletConnect

  • Improve UI on Select account modal
    Actual : Show duplicate unified account ( substrate and ton type)

    Image

    Expect :Show account name

  • Improve UI on walletconnect details screen

    Actual : Show duplicate unified account ( substrate and ton type)

    Image

    Expect : Show account name

  • Update content 's' for some screen
    Image

    Image

    Image

  • Error show TON address when connect Ethereum and Polkadot network
    Actual

    Image

    Expect : Show correct address

@ThaoNguyen998 ThaoNguyen998 added this to the Milestone 8 milestone Nov 19, 2024
@ThaoNguyen998 ThaoNguyen998 changed the title Mobile - Unified account - Bug related to Manage website asset Mobile - Unified account - Bug related to Connect dApp Nov 19, 2024
@giangtth17
Copy link
Collaborator

giangtth17 commented Dec 11, 2024

Still getting the error when retest

ConnectDApp.mp4

@giangtth17
Copy link
Collaborator

giangtth17 commented Dec 12, 2024

Version test: SubWallet v1.1.84(440)b-v11
Device test: Samsung S20

Reproduce the step:

  1. Select Avail Space or SubWallet
  2. Connect to 2 solo accounts
  3. At the Settings menu => select “Manage website access”
  4. Disable 1 of 2 accounts
  5. Return to the dApp to check

Actual:

  • Show "Connect to SubWallet" popup asking user to select account(s) to connect

  • Then some of the following cases occur:

    + Case 1 : User can click button "Cancel" => Navigate to the dApp screen (Pay attention to navigation)
    
Click_Cancel_1.mp4
Click_Cancel_2.mp4
  + Case 2:  User select account and click button "Connect" =>  Navigate to the dApp screen 
Click_Connect.mp4
  + Case 3 : User cannot click button "Cancel" or "Connect" => The screen is frozen, cannot continue any operations
Frozen.mp4

Expect: Navigate to the dApp screen and displays the account being connected

@Quangdm-cdm
Copy link
Collaborator

Quangdm-cdm commented Dec 12, 2024

This bug is currently still reproducing on the Extension. It needs to be resolved on the extension first, this bug should be created as a separate issue and the current issue should be closed. @ThaoNguyen998 @giangtth17

@giangtth17
Copy link
Collaborator

giangtth17 commented Dec 13, 2024

Version: SubWallet v1.1.84(440)b-v11
Device: Samsung S20

  • Update content 's' for WalletConnect screen
    Reproduce the steps:
    1. At WalletConnect, connect to 2 networks: EVM networks and Subtrate networks
    2. Select 1 account and click button Apply
    3. Check UI
      Actual:

image

Expect: Omit "s" if <=1 account

@giangtth17
Copy link
Collaborator

giangtth17 commented Dec 16, 2024

Version test:
1.
image

  1. SubWallet v1.1.84(440)b-v11

Device test:

  1. iPhone 8 Plus
  2. Samsung S20

Validation passed:

  1. Show correct status when connected dApp
IOS_correctStatus.mov
android_correctStatus.mp4
  1. Show correct list account on popup Connect account
IOS_CorrectListAccount.mov
Android_CorrectListAccount.mp4
  1. Hide address on list account connect on dApp details

image

image

  1. Padding

image

image


WalletConnect

  1. Improved UI on Select account modal => Show account name

image

image

  1. Improved UI on walletconnect details screen => Show account name

image

image

  1. Updated content 's' for some screen
    image
    image

image
image

image
image

  1. Show correct address when connect Ethereum and Polkadot network
    image
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants