Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize line ranges #22

Open
wrongu opened this issue Jun 12, 2023 · 2 comments
Open

generalize line ranges #22

wrongu opened this issue Jun 12, 2023 · 2 comments

Comments

@wrongu
Copy link
Contributor

wrongu commented Jun 12, 2023

option 1: move to char ranges

option 2: move to 'diff' semantics rather than selection ranges

...

option N: see discussion below

@wrongu wrongu changed the title move from line ranges to character ranges generalize line ranges Jun 12, 2023
@wrongu
Copy link
Contributor Author

wrongu commented Jun 12, 2023

on the one hand, would be nice for there to be a "document location" protocol, but then we can't put them into pydantic models.

still need to think more about the "right" way to have one data structure that can speak the languages of character offsets, parsed document trees, line ranges, etc. And think about how far we can get with quick and dirty hacks (like pretending everything is a character range)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants