Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new "View" options do not work with fuse_methods that require sigma #475

Open
Quasimondo opened this issue Sep 14, 2024 · 6 comments
Open

Comments

@Quasimondo
Copy link
Contributor

Unlike the regular context handler It looks like the new view handler does not pass the optional "sigma" argument to the get_context_weights() method which causes an error for those option that require sigma.

@Kosinkadink
Copy link
Owner

Can you point me to the code? I don't think I've modified view options code in a few months, so I'm not sure what you mean by new view options

@Quasimondo
Copy link
Contributor Author

Ah sorry, maybe they are not that new anymore (I was on holiday for the past weeks) - I am referring to these:
image

@Kosinkadink
Copy link
Owner

Ah, do the sigma related fuse methods only work on ContextOptions and not View Options?

@Quasimondo
Copy link
Contributor Author

Yes, that's what I am seeing here.

@Kosinkadink
Copy link
Owner

I should have time to implement the required changes at the end of September/beginning of October. Apologies for the delay, I am currently spending time on some core ComfyUI code, but by the end of that AnimateDiff-Evolved and Advanced-ControlNet will be able to have a cleaner codebase and new potential for features across all of ComfyUI custom nodes.

However, I think the changes required here should be simple though, as the timestep sigma would just need to be passed into somewhere from transformer_options. If you can find the changes required for context.py code to get that val for View Options, I can make a quick patch for it sometime this week.

@Quasimondo
Copy link
Contributor Author

Okay, thanks for the pointers - I'll dig around in those transformer_options and maybe I can find the right place where to pass the sigmas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants