Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K2] Sample analysis tests no longer pass with K2 analysis #3359

Closed
IgnatBeresnev opened this issue Nov 20, 2023 · 0 comments · Fixed by #3361
Closed

[K2] Sample analysis tests no longer pass with K2 analysis #3359

IgnatBeresnev opened this issue Nov 20, 2023 · 0 comments · Fixed by #3361
Assignees
Labels
tech-debt A technical issue that is not observable by the users, but improves maintainers quality of life topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Milestone

Comments

@IgnatBeresnev
Copy link
Member

IgnatBeresnev commented Nov 20, 2023

Unit tests that check @sample resolution (introduced in #3195) used to pass, but after #3195 they started failing.

Looking at the failing tests, I think it's because the symbol implementation can no longer resolve local functions, such as

/**
 * @sample bar
 */
fun foo() {
    
}

fun bar() {}

It's probable that the project sources are no longer added to the scope of sample analysis in the symbols implementation.


The tests can be found with FTS for TODO #3359.

@IgnatBeresnev IgnatBeresnev added tech-debt A technical issue that is not observable by the users, but improves maintainers quality of life topic: K2 Issues / PRs that are related to the K2 migration. See #2888 labels Nov 20, 2023
IgnatBeresnev added a commit that referenced this issue Nov 20, 2023
Should be addressed in #3359
@vmishenev vmishenev linked a pull request Nov 21, 2023 that will close this issue
@IgnatBeresnev IgnatBeresnev added this to the Dokka 1.9.20 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt A technical issue that is not observable by the users, but improves maintainers quality of life topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants