New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve invokeOnCompletion and invokeOnCancellation API #4180

Open

4 tasks

qwwdfsad opened this issue Jul 16, 2024 · 1 comment

Open

4 tasks

Improve invokeOnCompletion and invokeOnCancellation API #4180

qwwdfsad opened this issue Jul 16, 2024 · 1 comment

Labels

Collaborator

qwwdfsad commented Jul 16, 2024

Revisit documentation, explicitly spell out the purpose of the API, samplify
Mark it as delicate API
Short-cut it if necessary (Investigate possible shortcuts for coroutineContext.job.invokeOnCompletion { if (it != null) ... } #3259)
Shift invokeOnCompletion doesn't provide thread guarantees and doesn't allow to suspend #3505 and CancellableContinuation.invokeOnCancellation should accept a suspend callback #4154 towards a different API shape

The text was updated successfully, but these errors were encountered:

qwwdfsad added the enhancement label

qwwdfsad mentioned this issue

CancellableContinuation.invokeOnCancellation should accept a suspend callback #4154

Closed

Collaborator Author

qwwdfsad commented Jul 16, 2024

Also, we have #3065 which is similar to this one, but in a slightly different scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment