Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General] Output no longer outputs the initial conditions (i.e. time = 0 ) #12453

Open
mcgicjn2 opened this issue Jun 13, 2024 · 4 comments
Open

Comments

@mcgicjn2
Copy link
Contributor

mcgicjn2 commented Jun 13, 2024

Some time ago we noticed that after a commit that the initial conditions are not written to file. i.e. time = 0.

Although we understand this is not a necessity and should be known by a user as they input it however from our perspective it has 2 purposes:

  1. To clarify that the correct calculation processes are correct.
  2. To provide that output for GUI formats.

@mnabideltares Can you potentially track down the commit where this changed ? #11509 is the commit where this occurred

Was this removed by mistake or design ?

@mnabideltares
Copy link
Contributor

It is caused by:
c3ed8fd - Merge pull request #11509 from KratosMultiphysics/core/controllers/temporal_controller
5 Sep 2023 12:16

@matekelemen
Copy link
Contributor

I'm on holiday, but @sunethwarna might also be able to help you out with it.

@sunethwarna
Copy link
Member

Hi, is it happening in the vtk_output_process?

@mnabideltares
Copy link
Contributor

Hi, is it happening in the vtk_output_process?

@sunethwarna
Sorry for late reply. I was on holiday.
Thank you for looking in this issue. It seems it also occurs in the vtk output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants