Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Identical geometries in model part and geometry container #12703

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

rubenzorrilla
Copy link
Member

📝 Description
This PR introduces modifies the ModelPart and GeometryContainer implementation according to the conclusions reached in #12564. Long story short,

  • trying to add an existing geometry (by existing we understand same Id, type and connectivity) returns the already existing one rather than throwing an error
  • trying to add a geometry with an already existing Id but different type or connectivity (i.e., a different geometry with same Id) throws an error
  • trying to add a geometry with different Id but already existent connectivity is perfectly valid as this is considered a different entity (current behavior)

@jginternational this should solve your current issues.
@KratosMultiphysics/technical-committee I wonder if we should update the element and condition create methods accordingly.

Closes #12564.

@rubenzorrilla rubenzorrilla self-assigned this Sep 30, 2024
@rubenzorrilla rubenzorrilla requested a review from a team as a code owner September 30, 2024 07:06
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@pooyan-dadvand
Copy link
Member

@KratosMultiphysics/technical-committee approves this changes as discussed in #12564

Co-authored-by: Vicente Mataix Ferrándiz <[email protected]>
Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving since all suggestions have been addressed

@rubenzorrilla rubenzorrilla merged commit e5465ba into master Oct 1, 2024
9 of 11 checks passed
@rubenzorrilla rubenzorrilla deleted the core/identical-geometries-in-model-part branch October 1, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Repeated Identical Geometries in mdpa
4 participants