Geo/12646 pop for k0 procedure process #12651

WPK4FEM · 2024-08-28T09:03:09Z

📝 Description
Implementation of POP, documentation and unit testing of K0 procedure process.

🆕 Changelog

Added first setup of K0 README.md
Integration test for OCR without parameter field
Integration test for K0 with OCR
definition of POP and first implementation of POP in K0 procedure process
comparative tests for POP added
unit tests added for K0 procedure process
check function for input sanity check added

…er field.

…ncorrectly.

…ing attempt.

indigocoral

Thank you for all the work you have done on this. I have a couple of remarks which is more about the style. I'll discuss the questions I have with you later.

applications/GeoMechanicsApplication/custom_processes/README.md

applications/GeoMechanicsApplication/tests/test_k0_procedure_process.py

indigocoral · 2024-08-29T15:50:13Z

applications/GeoMechanicsApplication/tests/test_k0_procedure_process.py

+
+        # compare cauchy_stress_xx = k0 * cauchy_stress_yy, cauchy_stress_xy = 0.
+        k0_nc = 0.6
+        # POP 0.4 * sig'_yy_bottom


It is a bit unclear where 0.4 has come from. I think it needs more elaboration.

tried, please check the revised text.

indigocoral

Hi again :)
Thanks for the explanations to my questions. I've added some more comments (which we already discussed yesterday).

indigocoral · 2024-09-03T07:37:52Z

applications/GeoMechanicsApplication/custom_processes/apply_k0_procedure_process.cpp

        k0_vector *= rProp[OCR];
        array_1d<double, 3> correction(3, (PoissonUR / (1.0 - PoissonUR)) * (rProp[OCR] - 1.0));
        k0_vector -= correction;
+    } else if (rProp.Has(POP)) {
+        POP_value = -rProp[POP];


As we discussed, adding a comment would be helpful in understanding this line.

Tried, please read the added comment.

applications/GeoMechanicsApplication/custom_processes/README.md

...anicsApplication/tests/test_k0_procedure_process/test_k0_procedure_k0_nc_ocr_field/README.md

...eoMechanicsApplication/tests/test_k0_procedure_process/test_k0_procedure_k0_nc_pop/README.md

…mentation. Integration test needed.

rfaasse

Thank you for adding this functionality, next to minor comments (typo's etc), there are a few topics I think we should discuss:

How do we want to deal with the plx results? I'm not sure if adding these plx.res files and comparing all integration points is the right way to go.
A related point is, do we want to be explicit with mentioning plaxis in this open source package? To me it seems risky.
There is an extensive integration test suite, but I would be very much in favor of also adding unit tests.
The integration tests become easier to review if there's a schematic to go with it (since the meshes are quite large and not easy to visualize)

...Application/tests/test_k0_procedure_process/test_k0_procedure_phi_pop_layers/plx_results.res

...icsApplication/tests/test_k0_procedure_process/test_k0_procedure_phi_pop_layers/plxMesh.mdpa

applications/GeoMechanicsApplication/custom_processes/README.md

applications/GeoMechanicsApplication/tests/test_k0_procedure_process/README.md

...ns/GeoMechanicsApplication/tests/test_k0_procedure_process/test_k0_procedure_k0_nc/README.md

...eoMechanicsApplication/tests/test_k0_procedure_process/test_k0_procedure_k0_nc_ocr/README.md

...ication/tests/test_k0_procedure_process/test_k0_procedure_k0_nc_ocr/MaterialParameters1.json

...nicsApplication/tests/test_k0_procedure_process/test_k0_procedure_k0_nc_pop_layers/README.md

…nd cleaned up the unit test and added a successful call to the Check function

…0_procedure_process' into geo/12646_pop_for_k0_procedure_process

indigocoral

Wijtze Pieter,
Thank you very much for your work on this. It is very valuable to get POP in K0 procedure process. I have very few minor suggestions on the documentation. And I have also asked my questions to you so all is clear to me. I did not get the chance to review the code unfortunately but I will push my comments anyway. Thank you!

applications/GeoMechanicsApplication/custom_processes/README.md

avdg81

This looks like a clean and well-tested PR to me. I have several suggestions and questions, but nothing major. To all contributors: well done!

applications/GeoMechanicsApplication/custom_processes/README.md

applications/GeoMechanicsApplication/custom_processes/apply_k0_procedure_process.cpp

...sApplication/tests/test_k0_procedure_process/test_k0_procedure_k0_nc_pop_layers/plxMesh.mdpa

...ion/tests/test_k0_procedure_process/test_k0_procedure_phi_pop_layers/MaterialParameters.json

...tion/tests/test_k0_procedure_process/test_k0_procedure_phi_pop_layers/ProjectParameters.json

...hanicsApplication/tests/test_k0_procedure_process/test_k0_procedure_phi_pop_layers/README.md

...icsApplication/tests/test_k0_procedure_process/test_k0_procedure_phi_pop_layers/plxMesh.mdpa

…due to faulty rendering on GitHub.

avdg81

Thank you very much to all contributors for the time and effort that you have put into this. I believe this PR is ready to be merged.

WPK4FEM added 6 commits August 28, 2024 09:33

Renamed k0 test with ocr to reflect that the ocr comes from a paramet…

5a6b4b1

…er field.

Text improvements in documentation.

c2f1890

added k0 test with ocr from material input.

6e91d38

First README attempt for K0 procedure process. Formula's may format i…

611d2f3

…ncorrectly.

Use the intended K0_NC syntax i.s.o. the directional K0 values.

2a9006f

First POP definition and integration test added.

8e28b3d

WPK4FEM requested a review from indigocoral August 28, 2024 09:03

WPK4FEM self-assigned this Aug 28, 2024

WPK4FEM linked an issue Aug 28, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Preparation for applying the POP in the K0 procedure process #12646

Closed

WPK4FEM requested review from mcgicjn2 and avdg81 August 28, 2024 11:29

WPK4FEM added 4 commits August 28, 2024 13:44

attempting to fix formula formatting K0

4e25c50

Further attempt to correct formulas

ffbee40

Marjans suggestion of how to write K_{0_{NC}} and next matrix formatt…

3eb5f7d

…ing attempt.

Just to check if extra {} cure anything.

c2e97db

indigocoral reviewed Aug 29, 2024

View reviewed changes

indigocoral reviewed Sep 3, 2024

View reviewed changes

WPK4FEM added 6 commits September 3, 2024 11:27

First review comments by Marjan taken up.

2f8f156

Further review comments by Marjan taken up.

e467de9

Added references to the extra tests in the parent directory.

3177070

Correction with Poisson_un_reloading for POP. Implementation and docu…

15d8445

…mentation. Integration test needed.

Refactoring for code complexity. Improved error text.

44d2c31

Const declared function.

ac9714c

rfaasse reviewed Sep 30, 2024

View reviewed changes

WPK4FEM added 5 commits October 2, 2024 16:07

added K_0 procedure to list of documented processes.

7804542

Spelling alternatively corrected.

b5633b1

iterate over integration point stress vectors to avoid raw loop.

817fa39

Layout request of Richards review.

357bb4b

OCR in upper case ( review by Richard )

ea3a2e7

WPK4FEM force-pushed the geo/12646_pop_for_k0_procedure_process branch from 0ad4931 to ea3a2e7 Compare October 2, 2024 15:10

rfaasse and others added 12 commits October 8, 2024 13:51

Removed checks in the process that were moved to the Check function a…

e1be256

…nd cleaned up the unit test and added a successful call to the Check function

Changed test name

0e3f3c3

Refactored to remove code smells and clang-tidy issues

27e8535

Refactored to remove code smells and clang-tidy issues in the test file

e596038

Attempt to write documentation for use_standard_process.

84d591b

Merge remote-tracking branch 'refs/remotes/origin/geo/12646_pop_for_k…

dcd682f

…0_procedure_process' into geo/12646_pop_for_k0_procedure_process

Fixing tests after merge with master and stricter testing

384ef89

Reverted some changes and put them in a different branch

5e3c0df

Reverted test_helper mistake

c4ad332

Merge remote-tracking branch 'refs/remotes/origin/geo/12646_pop_for_k…

02339f0

…0_procedure_process' into geo/12646_pop_for_k0_procedure_process

Formatting

b0a8ddd

Bound checking and unit tests for OCR and POP ranges.

1ec06ed

indigocoral previously approved these changes Oct 10, 2024

View reviewed changes

WPK4FEM added 2 commits October 10, 2024 16:42

More range checks, reformatting and empty statements removed.

4e47c89

Review comments of Marjan.

34d0b91

WPK4FEM dismissed indigocoral’s stale review via 34d0b91 October 10, 2024 15:09

avdg81 reviewed Oct 10, 2024

View reviewed changes

WPK4FEM added 8 commits October 11, 2024 09:10

Review comments of Marjan and Anne on manual page.

967bf47

Review comments of Anne on implementation.

8a86121

Included element.h in test.

de09884

Removed unused code discovered in review by Anne.

370b51c

Renamed to avoid plx

1b2c43e

superscripts and Greed \nu in README.

f35272a

Redundant comment removed, redundant material parameters removed.

89dc75b

Removed redundant material parameters, replaced formulas by pictures …

5ed7723

…due to faulty rendering on GitHub.

WPK4FEM marked this pull request as ready for review October 11, 2024 09:02

re-formatted.

a5f7bb7

avdg81 approved these changes Oct 11, 2024

View reviewed changes

WPK4FEM merged commit dfc8f8e into master Oct 11, 2024
9 of 11 checks passed

WPK4FEM deleted the geo/12646_pop_for_k0_procedure_process branch October 11, 2024 11:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Geo/12646 pop for k0 procedure process #12651

Geo/12646 pop for k0 procedure process #12651

WPK4FEM commented Aug 28, 2024 •

edited

Loading

indigocoral left a comment

indigocoral Aug 29, 2024 •

edited

Loading

WPK4FEM Sep 3, 2024

indigocoral left a comment

indigocoral Sep 3, 2024

WPK4FEM Sep 3, 2024

rfaasse left a comment

indigocoral left a comment

avdg81 left a comment

avdg81 left a comment

Geo/12646 pop for k0 procedure process #12651

Geo/12646 pop for k0 procedure process #12651

Conversation

WPK4FEM commented Aug 28, 2024 • edited Loading

indigocoral left a comment

Choose a reason for hiding this comment

indigocoral Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

WPK4FEM Sep 3, 2024

Choose a reason for hiding this comment

indigocoral left a comment

Choose a reason for hiding this comment

indigocoral Sep 3, 2024

Choose a reason for hiding this comment

WPK4FEM Sep 3, 2024

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

indigocoral left a comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

WPK4FEM commented Aug 28, 2024 •

edited

Loading

indigocoral Aug 29, 2024 •

edited

Loading