Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Modify DbSet to not use CommandGenerator directly #8

Open
Mikado3780 opened this issue Apr 18, 2018 · 0 comments
Open

Modify DbSet to not use CommandGenerator directly #8

Mikado3780 opened this issue Apr 18, 2018 · 0 comments

Comments

@Mikado3780
Copy link
Collaborator

Mikado3780 commented Apr 18, 2018

  • Modify DbSet to not use CommandGenerator directly, but only IQueryProvider.
  • CommandGenerator is class for creating commands for DbSet. But in case of database connection, it relies on IQueryProvider. IQueryProvider creates instance of DbCommand, because it knows database connection. Because of that, there is useless method GetCommandForCurrentTransaction.
  • It would be great if the DbSet will be dependent only on IQueryProvider and IQueryProvider will use CommandGenerator inside. Consider deleting CommandGenerator and moving code to IQueryProvider.
@Mikado3780 Mikado3780 changed the title Modify DbSet to not use CommandGenerator directly. Modify DbSet to not use CommandGenerator directly Apr 18, 2018
@LukasSefcik LukasSefcik self-assigned this May 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants