Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goggles crashes when a package cannot be parsed due to syntax error #31

Open
integrii opened this issue Mar 24, 2017 · 6 comments
Open
Labels

Comments

@integrii
Copy link

Various experiments when searching other things reveals that it crashes when I select any of my private home-ai repos.

@KyleBanks
Copy link
Owner

Well that's no good, could you post the last 10 or so lines of ~/Library/Logs/goggles.log?

@KyleBanks
Copy link
Owner

I don't see it in your repository list so I'm guessing it's a private repo right?

@integrii
Copy link
Author

integrii commented Apr 8, 2017

Thanks for writing back. Sorry about the delay. I have a new son since I posted this issue.

Yes, nearly all our repos are private. Here is the crashing line from the log you mentioned. Was this trying to compile some of my code when it crashed?!

2017/04/07 20:07:19 /Users/eg/go/src/github.com/home-ai/main.go:40:1: expected operand, found '}'

I quickly ran a rm -f /Users/eg/go/src/github.com/home-ai/main.go and everything works as expected now.

Looks like for some reason it was trying to compile this random out of place main.go file?!

@KyleBanks
Copy link
Owner

@integrii thanks for the response and congratulations on the new baby!

Goggles doesn't compile or execute any of your code, but it does use the go/build package to parse and analyze the source code. This is the same internal package used by GoDoc, the various go commands (build, install, vet, etc), and many other tools.

If the source code can't be compiled Goggles would definitely fail to parse it, so I'm going to retitle this issue to simply ignore packages that cannot be compiled, rather than crashing.

@KyleBanks KyleBanks changed the title When I search for my "home-ai" in native mode, the app closes upon typing "-" Goggles crashes when a package cannot be parsed due to syntax error Apr 8, 2017
@integrii
Copy link
Author

Perfect! Thanks @KyleBanks. I love the project.

@CyDoor
Copy link

CyDoor commented Apr 24, 2017

Kyle, first of all -> Hell i <3 Goggle
Unfortunately facing the same issues -> The Term is crashing
stable bin x64 on win 10
Where does the bin throwing the logs ouut :-)?

Edit:// Still dont find the logs, do i have to build it from the source to enjoy them?
-> i figured out that i could scroll through my near countless sources without any problem, even searching works BUT if i search "rsa" to find the crypto/rsa source it crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants