Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MakeSnapshot should be ignored when nothing has changed since last snapshot #81

Open
KyrietS opened this issue Jun 5, 2024 · 0 comments
Open

MakeSnapshot should be ignored when nothing has changed since last snapshot #81

KyrietS opened this issue Jun 5, 2024 · 0 comments
Labels
improvement Code refactor or minor changes that are not new features

Comments

@KyrietS
Copy link
Owner

KyrietS commented Jun 5, 2024

Making snapshot identical to the previous one never makes sense. Apart from discarding such snapshot application should also print some sinister warning log.

To implement this I need a way to compare CanvasElements. It is not trivial now as elements don't have operator==.
@KyrietS KyrietS added the improvement Code refactor or minor changes that are not new features label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Code refactor or minor changes that are not new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KyrietS