ENH: Add OTP processing option #356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SNR plots to _report.py
add run_opt
larsoner
reviewed
Feb 7, 2022
There was a problem hiding this comment.
@mdclarke looks like it's close! I pushed some commits to fix the CIs. CircleCI was broken and Travis wasn't running, so I fixed those. Then in terms of your changes, I had to change the order of some stuff to make the YAML match the overview.rst.
I think what's left is:
- Update the flowchart by changing https://github.com/LABSN/mnefun/blob/main/mnefun/_flow.py
- Make it so that the SSS step uses either the raw files (if otp_dur is None) or the OTP'ed files (if otp_dur is not None)
add OTP
Codecov Report
@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage ? 20.09%
=======================================
Files ? 34
Lines ? 5185
Branches ? 0
=======================================
Hits ? 1042
Misses ? 4143
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #355