sfwbar-git-r1705.818813f volume.widget problem #290
Comments
|
expand/collapse should be fixed hopefully. Will check the device output as
well
…On Sat, Dec 21, 2024 at 7:31 AM sfs-pra ***@***.***> wrote:
2 devices:
Built-in Audio
Bluetootch headphones
1. Volume.widget does not switch the output device
2. “expand/collapse channel” - the first press expands the list. The
second press does not close the list
All this worked in sfwbar-git-r1622.64b65ff
—
Reply to this email directly, view it on GitHub
<#290>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASHPFFDB5GR453SZPFO54IT2GUKORAVCNFSM6AAAAABUAMAHIKVHI2DSMVQWIX3LMV43ASLTON2WKOZSG42TGOBSGM3TQNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
sfwbar-git-r1707.53cb1e0
|
|
The output device selector broke for a good reason. This configuration
patterns relied on a really ugly config grammar pattern (action could only
have 2 parameters), so menu item could me MenuItem("title", action "action
parameter1", "action parameter 2", "menu item id"). I.e. a parameter list
after action attributed the first two parameters to action and the third
one to MenuItem. This only works if action you're attaching has exactly two
parameters and breaks with the new parser which allows action to have any
number of parameters.
This should be fixed once I migrate the user defined functions to vm
parser. The new grammar, once implemented should be something like:
MenuItem("title", { action "param1", param2" }, "menu item id");
…On Sat, Dec 21, 2024 at 5:21 PM Lev Babiev ***@***.***> wrote:
expand/collapse should be fixed hopefully. Will check the device output as
well
On Sat, Dec 21, 2024 at 7:31 AM sfs-pra ***@***.***> wrote:
> 2 devices:
> Built-in Audio
> Bluetootch headphones
>
> 1. Volume.widget does not switch the output device
> 2. “expand/collapse channel” - the first press expands the list. The
> second press does not close the list
>
> All this worked in sfwbar-git-r1622.64b65ff
>
> —
> Reply to this email directly, view it on GitHub
> <#290>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ASHPFFDB5GR453SZPFO54IT2GUKORAVCNFSM6AAAAABUAMAHIKVHI2DSMVQWIX3LMV43ASLTON2WKOZSG42TGOBSGM3TQNA>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
|
I think it took me longer to write the previous message than to write the
code to fix the issue. Can you test the latest git please? (please note
that you need volume.widget from the last git version as well, in case you
made a local copy).
…On Sat, Dec 21, 2024 at 8:33 PM Lev Babiev ***@***.***> wrote:
The output device selector broke for a good reason. This configuration
patterns relied on a really ugly config grammar pattern (action could only
have 2 parameters), so menu item could me MenuItem("title", action "action
parameter1", "action parameter 2", "menu item id"). I.e. a parameter list
after action attributed the first two parameters to action and the third
one to MenuItem. This only works if action you're attaching has exactly two
parameters and breaks with the new parser which allows action to have any
number of parameters.
This should be fixed once I migrate the user defined functions to vm
parser. The new grammar, once implemented should be something like:
MenuItem("title", { action "param1", param2" }, "menu item id");
On Sat, Dec 21, 2024 at 5:21 PM Lev Babiev ***@***.***> wrote:
> expand/collapse should be fixed hopefully. Will check the device output
> as well
>
> On Sat, Dec 21, 2024 at 7:31 AM sfs-pra ***@***.***> wrote:
>
>> 2 devices:
>> Built-in Audio
>> Bluetootch headphones
>>
>> 1. Volume.widget does not switch the output device
>> 2. “expand/collapse channel” - the first press expands the list. The
>> second press does not close the list
>>
>> All this worked in sfwbar-git-r1622.64b65ff
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#290>, or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ASHPFFDB5GR453SZPFO54IT2GUKORAVCNFSM6AAAAABUAMAHIKVHI2DSMVQWIX3LMV43ASLTON2WKOZSG42TGOBSGM3TQNA>
>> .
>> You are receiving this because you are subscribed to this thread.Message
>> ID: ***@***.***>
>>
>
|
|
sfwbar-git-r1708.074284a + new volume.widget = problem solved If you set the default "build-in" - the sound from the speaker-test goes to the headphones. It can be switched only on the speaker-test stream |
|
This is a bit confusing, but the default setting in sfwbar selects the
device which sfwbar will control by default (i.e. if you scroll over the
volume control icon). It does not set the default sink or source currently.
It would be easy to implement, but we'll need some disambiguation of
terminology, i.e. default sink vs default control sink or some such.
…On Sat, Dec 21, 2024 at 10:56 PM sfs-pra ***@***.***> wrote:
sfwbar-git-r1708.074284a + new volume.widget = problem solved
If you set the default "build-in" - the sound from the speaker-test goes
to the headphones. It can be switched only on the speaker-test stream
Maybe that's the way it should be...
—
Reply to this email directly, view it on GitHub
<#290 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASHPFFGIMJAXIVV2W4TRGE32GXWYRAVCNFSM6AAAAABUAMAHIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJYGI3DCNJTG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I would like to be able to choose the device on which to play the sound of all applications. I.e. switch all sounds from speakers to headphones and vice versa |
|
Ask and you shall receive. I added command set-default-device which sets
the default sink.source. I wired it into a widget though a menu, you can
right click on the device name and select "Set Device As Default". It's not
the best interface. In general we'll need to think about the interaction
between the default device for purposes of pulse and the default device for
the purpose of sfwbar control.
…On Sun, Dec 22, 2024 at 6:32 PM sfs-pra ***@***.***> wrote:
I would like to be able to choose the device on which to play the sound of
all applications. I.e. switch all sounds from speakers to headphones and
vice versa
—
Reply to this email directly, view it on GitHub
<#290 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASHPFFBWQ7KZA3R6ESRTACD2G4AVDAVCNFSM6AAAAABUAMAHIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJYGU2TAMRXGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
sfwbar-git-r1710.d16e095 Then what should the checkbox “set as default sink” do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 devices:
Built-in Audio
Bluetootch headphones
All this worked in sfwbar-git-r1622.64b65ff
The text was updated successfully, but these errors were encountered: