Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pass name to tracking code (CKFProcessor, Vertexing, etc) #1481

Open
tvami opened this issue Sep 30, 2024 · 2 comments
Open

Add pass name to tracking code (CKFProcessor, Vertexing, etc) #1481

tvami opened this issue Sep 30, 2024 · 2 comments

Comments

@tvami
Copy link
Member

tvami commented Sep 30, 2024

Is your feature request related to a problem? Please describe.

Filippo was running ACTSv35 on an existing eN sample where the tracking branches were already created and ran into the issue of

[ fire ] 1 fatal: [ProductAmbiguous] : Multiple products found for name 'RecoilTruthSeeds' without specified pass name :
{ name = RecoilTruthSeeds, pass = genie_reco, type = vector<ldmx::Track>}
{ name = RecoilTruthSeeds, pass = genie_reco_v36, type = vector<ldmx::Track>}
  at /Users/fdelzanno/Desktop/Incandela/Coding/ldmx-sw/Framework/include/Framework/Event.h:300 in getObject

Describe the solution you'd like

this

event.getCollection<ldmx::Track>(seed_coll_name_);

 event.getCollection<ldmx::Track>(seed_coll_name_);

should be

 event.getCollection<ldmx::Track>(seed_coll_name_, input_pass_name_);

probably true for the vertexer and other processors in the tracking.

Describe alternatives you've considered

Dropping the old collection and running on the new one in two steps. But this wont allow comparisons in one config for sure

@bryngemark
Copy link
Contributor

good catch, configurable input collection and pass names, and output collection names, should be standard for all processors in my opinion

@tvami tvami self-assigned this Sep 30, 2024
@tvami
Copy link
Member Author

tvami commented Sep 30, 2024

Yes, I agree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants