Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils::sqrt should probably return an error for negative values #57

Open
maurges opened this issue Sep 7, 2023 · 0 comments
Open

utils::sqrt should probably return an error for negative values #57

maurges opened this issue Sep 7, 2023 · 0 comments

Comments

@maurges
Copy link
Contributor

maurges commented Sep 7, 2023

Having it return 1 moves the error into ZK proofs, which might be hard to debug.
@survived survived added the enhancement New feature or request label Jan 30, 2024
@survived survived removed the enhancement New feature or request label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maurges @survived