Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change interface of NI proofs #29

Open
survived opened this issue May 3, 2023 · 1 comment
Open

Change interface of NI proofs #29

survived opened this issue May 3, 2023 · 1 comment
Assignees
@maurges

Comments

@survived
Copy link
Contributor

survived commented May 3, 2023

NI proofs accept shared_state: impl Digest which doesn't actually make sense. We should replace it with shared_state: impl AsRef<[u8]>
@survived survived mentioned this issue May 3, 2023
Merged
@maurges
Copy link
Contributor

maurges commented May 3, 2023

I want to make this change with another change: moving to struct-of-refs for every argument, like we do for some proofs already.

@maurges maurges self-assigned this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurges maurges

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maurges @survived