Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in RGB difference calculation #1

Open
ghost opened this issue Feb 1, 2017 · 2 comments
Open

Error in RGB difference calculation #1

ghost opened this issue Feb 1, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 1, 2017

In convert.py, line 36, you have:
b2 = a /32 / 32 % 32
It should be:
b2 = b /32 / 32 % 32

Keep up the good work, love this program and the concept!

@LIJI32
Copy link
Owner

LIJI32 commented Feb 3, 2017

Whoops! I'll fix it and re-encode the video once I have time. Good to know somebody actually read that code! :)

@ghost
Copy link
Author

ghost commented Feb 5, 2017

I'm happy I could help! I was just trying to help, and also maybe see if I can find the bug in my emulator. There's something incredibly obscure, it works for Pokemon Red and Tetris, but Mario crashes after about 30 seconds of play and I don't know why. Just thought that this, being written exactly to the hardware, might help me debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant