We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem? Please describe.
In #1738, it was discovered that TensorIndex did not handle strongly typed indices, and was fixed directly in that PR.
TensorIndex
Describe the solution you'd like
Tests using strongly typed indices with TensorIndex are missing, and we should add them. The cases which need covering are:
VectorIndex<strongtypedindex, vector> RowIndex<strongtypedindex, vector> ColIndex<strongtypedindex, vector>
VectorIndex<strongtypedindex, vector>
RowIndex<strongtypedindex, vector>
ColIndex<strongtypedindex, vector>
See RAJA/benchmarks/ltimes.cpp for use cases.
RAJA/benchmarks/ltimes.cpp
The text was updated successfully, but these errors were encountered:
Also check whether this implementation of range() should be index_type or value_type. Use range() with strongly typed indices in tests.
range()
index_type
value_type
RAJA/include/RAJA/pattern/tensor/TensorIndex.hpp
Line 67 in 6280cd6
Sorry, something went wrong.
rchen20
No branches or pull requests
Is your feature request related to a problem? Please describe.
In #1738, it was discovered that
TensorIndex
did not handle strongly typed indices, and was fixed directly in that PR.Describe the solution you'd like
Tests using strongly typed indices with
TensorIndex
are missing, and we should add them. The cases which need covering are:VectorIndex<strongtypedindex, vector>
RowIndex<strongtypedindex, vector>
ColIndex<strongtypedindex, vector>
See
RAJA/benchmarks/ltimes.cpp
for use cases.The text was updated successfully, but these errors were encountered: