Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests for Strongly Typed Indices for TensorIndex #1745

Open
rchen20 opened this issue Sep 27, 2024 · 1 comment
Open

Add Tests for Strongly Typed Indices for TensorIndex #1745

rchen20 opened this issue Sep 27, 2024 · 1 comment
Assignees
Labels
reviewed Mark with this label when issue has been discussed by team testing

Comments

@rchen20
Copy link
Member

rchen20 commented Sep 27, 2024

Is your feature request related to a problem? Please describe.

In #1738, it was discovered that TensorIndex did not handle strongly typed indices, and was fixed directly in that PR.

Describe the solution you'd like

Tests using strongly typed indices with TensorIndex are missing, and we should add them. The cases which need covering are:

VectorIndex<strongtypedindex, vector>
RowIndex<strongtypedindex, vector>
ColIndex<strongtypedindex, vector>

See RAJA/benchmarks/ltimes.cpp for use cases.

@rchen20 rchen20 self-assigned this Sep 27, 2024
@rchen20
Copy link
Member Author

rchen20 commented Oct 9, 2024

Also check whether this implementation of range() should be index_type or value_type. Use range() with strongly typed indices in tests.

self_type range(index_type begin, index_type end){

@rhornung67 rhornung67 added testing reviewed Mark with this label when issue has been discussed by team labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Mark with this label when issue has been discussed by team testing
Projects
None yet
Development

No branches or pull requests

2 participants