Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making timeout units consistent #811

Open
wangvsa opened this issue Apr 2, 2024 · 0 comments
Open

Making timeout units consistent #811

wangvsa opened this issue Apr 2, 2024 · 0 comments

Comments

@wangvsa
Copy link
Collaborator

wangvsa commented Apr 2, 2024

Current configuration allows setting three timeouts, but they don't use the same unit.

margo section:

  • client_timeout: timeout in milliseconds for rpcs between client and server (default: 5000)
  • server_timeout: timeout in milliseconds for rpcs between servers (default: 15000)

server section:

  • init_timeout: timeout in seconds to wait for servers to be ready for clients (default: 120)

Maybe better to make the three timeout units the same? Probably all use seconds.
Otherwise, It can be confusing when checking a job script with all three environment variables:

export UNIFYFS_SERVER_INIT_TIMEOUT=600
export UNIFYFS_MARGO_CLIENT_TIMEOUT=60000
export UNIFYFS_MARGO_SERVER_TIMEOUT=60000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant