Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextFloat does not work under Wayland #7626

Open
1 task done
michaelgregorius opened this issue Dec 19, 2024 · 7 comments
Open
1 task done

TextFloat does not work under Wayland #7626

michaelgregorius opened this issue Dec 19, 2024 · 7 comments
Labels

Comments

@michaelgregorius
Copy link
Contributor

michaelgregorius commented Dec 19, 2024

System Information

Arch Linux with Wayland

LMMS Version(s)

master

Bug Summary

Positioning the text float window does not work under Wayland. All text floats are shown at position (0, 0) instead of at the lower left corner of the main window like under X11.

The reason is that TextFloat::moveGlobal uses QWidget::move which is not supported under Wayland.

Expected Behaviour

The text float should not show at (0, 0).

Proposal: Implement a dedicated area where messages are shown and collected instead of using an ephemeral text float which users might miss to notice anyway.

Steps To Reproduce

Open a project that has been created with an older version of LMMS so that the text float which shows that information is displayed.

Please search the issue tracker for existing bug reports before submitting your own.

  • I have searched all existing issues and confirmed that this is not a duplicate.
@regulus79
Copy link
Contributor

I am on Arch Linux, Wayland, GNOME 47, and I cannot reproduce this issue. The TextFloats appear at the bottom left as usual for me.

@michaelgregorius
Copy link
Contributor Author

Here's how it looks under KDE/Plasma with Wayland:

TextFloatWithKDEPlasma.webm

It's a bit surprising that it seems to work under Gnome as it is stated that Wayland does not allow clients to place windows. Are you sure that you are triggering a case where the text float window is a top-level window without a parent, e.g. in the way as described above?

@regulus79
Copy link
Contributor

2024-12-20.11-31-27.mp4

@Rossmaxx

This comment was marked as off-topic.

@Rossmaxx
Copy link
Contributor

Oops, wrong issue. Thought this was the PR.

@regulus79
Copy link
Contributor

On closer inspection it appears that LMMS may not have been running on Wayland. Although GNOME says that my windowing system is Wayland, and everything I have checked appears to show that I am running Wayland, LMMS gives the following warning when it starts up:
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
I am not an expert on windowing systems, so I'm not sure what else it would be running on (XWayland?) But sure enough, when I set QT_QPA_PLATFORM=wayland, the LMMS window looks different, and I can reproduce this issue of the text floats spawning in the top left.

@michaelgregorius
Copy link
Contributor Author

Yes, I guess that it is running through XWayland and that it therefore shows the same behavior as under X11. Although it's also interesting that the placing of windows seems to be allowed then under this setup. However that works. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants