Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I don't understand the TX import logic #315

Closed
marina-ricci opened this issue Jul 20, 2023 · 2 comments
Closed

I don't understand the TX import logic #315

marina-ricci opened this issue Jul 20, 2023 · 2 comments

Comments

@marina-ricci
Copy link
Contributor

This is more of a comment for @joezuntz. I noticed that the way the import are written in the init files, we are often importing all functions without asking it explicitly. Is it a deliberate choice? I find it quite confusing.

For instance, the CLClusterShearCatalogs pipeline stage was imported just from the line from .extensions.clmm import TXTwoPointRLens in /txpipe/__init__.
@joezuntz
Copy link
Collaborator

You mean why are we doing from .clmm import * and things like that? I don't think any particular reason, if you'd like to change it please do.

@joezuntz
Copy link
Collaborator

joezuntz commented Nov 8, 2024

I think this is okay now?

@joezuntz joezuntz closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joezuntz @marina-ricci