Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Bunis HSPC data getter #28

Open
LTLA opened this issue Jan 30, 2021 · 4 comments
Open

Add a Bunis HSPC data getter #28

LTLA opened this issue Jan 30, 2021 · 4 comments

Comments

@LTLA
Copy link
Owner

LTLA commented Jan 30, 2021

@dtm2451 the time has cometh. Should be as simple as copying one of the other getters to BunisHSPCData.R, renaming the function and changing the path to bunis-hspc.

  • Make sure you set rowdata=TRUE in .create_sce() to get the row data.
  • Add yourself to Authors@R.
  • Add the dataset to inst/extdata/manifest.csv.
  • Add some basic tests to longtests/.
@LTLA
Copy link
Owner Author

LTLA commented Feb 17, 2021

So, uh, Dr Bunis. Any plans for this, or what?

@dtm2451
Copy link
Contributor

dtm2451 commented Feb 17, 2021

Yes yes! Fell off my radar, but it's back on for this week. I'll put something together by the weekend.

@dtm2451
Copy link
Contributor

dtm2451 commented Apr 29, 2021

I'm not sure of the best ways to convert from dgT to dgC, but the counts matrix is already dgT right out of

mat <- Matrix::readMM(mat.path)
.

Might as well add the conversion right around there, no?

@LTLA
Copy link
Owner Author

LTLA commented Apr 29, 2021

Oh crap, didn't notice that's where it was coming from. Yes, the conversion would be done there. I can do that myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants