Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in tracking.py - hardcoded curvature value #40

Open
davegrays opened this issue Apr 1, 2016 · 3 comments
Open

bug in tracking.py - hardcoded curvature value #40

davegrays opened this issue Apr 1, 2016 · 3 comments
Assignees
Labels

Comments

@davegrays
Copy link

Running CMP from commandline, the value for is not recognized from the .ini file. Instead it appears to be hardocded depending on whether you run probabilistic or deterministic tractography.

If I comment out the _SD_changed() and _tracking_mode_changed() methods in cmp_nipype/cmp/stages/diffusion/tracking.py (lines 66 and 74), that fixes the problem. But assuming these are intended to provide default values in the GUI, I'm guessing there's a better solution. There's also a similar looking method for the Camino_tracking_config - I don't know if that will pose a similar problem.

@daducci daducci added the bug label Apr 2, 2016
@daducci daducci assigned daducci and davidrs06 and unassigned daducci Apr 2, 2016
@daducci
Copy link

daducci commented Apr 2, 2016

@davidrs06 , can you have a look at this?

@davidrs06
Copy link
Contributor

Hello davegrays ! Could you provide more details on how you are using the CMP from commandline ? If I create a config file and set the mrtrix tracking curvature to be 3.0 (as opposed to the 2.0 default value) and run the following code inside python:
import cmp.gui
project = cmp.gui.CMP_Project_Info()
project.base_directory = '/my/base/directory'
project.config_file = '/my/diffusion/config.ini'
pipeline = cmp.project.init_project(project, False)
valid_inputs = pipeline.check_input(gui=False)
print(pipeline.stages['Diffusion'].config.mrtrix_tracking_config.curvature)

The returned value is 3.0, as specified in the config file.

@davegrays
Copy link
Author

Hi David,

I am just running 'connectomemapper subjectID config.ini' from the linux
command prompt, where I have set the mrtrix curvature to 1 or 3 in the
config.ini. In either case it runs streamtrack with a curvature value of 2.

-David

On Mon, Apr 4, 2016 at 2:41 AM, David Romascano [email protected]
wrote:

Hello davegrays ! Could you provide more details on how you are using the
CMP from commandline ? If I create a config file and set the mrtrix
tracking curvature to be 3.0 (as opposed to the 2.0 default value) and run
the following code inside python:
import cmp.gui
project = cmp.gui.CMP_Project_Info()
project.base_directory = '/my/base/directory'
project.config_file = '/my/diffusion/config.ini'
pipeline = cmp.project.init_project(project, False)
valid_inputs = pipeline.check_input(gui=False)
print(pipeline.stages['Diffusion'].config.mrtrix_tracking_config.curvature)

The returned value is 3.0, as specified in the config file.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#40 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants